[IDE] Add internal parameter names in signature help #84272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
a7medev
commented
Sep 13, 2025
|
|
||
| // Documentation. | ||
| if (FD) { | ||
| // TODO(a7medev): Separate parameter documentation. |
There was a problem hiding this comment.
Parameter documentation separation will be implemented in SourceKit-LSP. Check swiftlang/sourcekit-lsp#2292 for more details on why that's the case.
|
@swift-ci please test |
hamishknight
approved these changes
Sep 15, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds internal parameter names for signature help parameters.
This allows SourceKit-LSP to parse the documentation comment, extract parameter documentation, and match it with the parameters using the parameter name.